Fix null check logic error in mapToJson method#14
Open
marko-kriskovic wants to merge 1 commit intomainfrom
Open
Fix null check logic error in mapToJson method#14marko-kriskovic wants to merge 1 commit intomainfrom
marko-kriskovic wants to merge 1 commit intomainfrom
Conversation
Fixed logic error in mapToJson where the null check was inverted. Changed 'if (map != null)' to 'if (map == null)' to properly throw IllegalArgumentException when map is null, not when it's valid. Fixes #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical logic error in the
JsonMapConverter.mapToJson()method where the null check condition was inverted.Problem
The method had
if (map != null)which caused it to:IllegalArgumentExceptionwhen a valid (non-null) map was passedSolution
Changed line 41 from:
to:
Tests Fixed
This fix resolves all the failing tests mentioned in issue #13:
testMapToJson_SimpleMaptestMapToJson_NestedMaptestMapToJson_EmptyMaptestMapToJson_NullInputtestRoundTrip_JsonToMapToJsonFixes #13